Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Slack sync upstream/2018 02 07 #71

Merged
merged 6 commits into from
Feb 7, 2018
Merged

Slack sync upstream/2018 02 07 #71

merged 6 commits into from
Feb 7, 2018

Conversation

rafael
Copy link

@rafael rafael commented Feb 7, 2018

Description.

  • Cherry picks two small fixes in SQL parsing:
  1. Issue with create statements and using USING identifier: add support for USING <identifier> to CREATE TABLE vitessio/vitess#3633
  2. Fix for SQL preview in vtgate where it was failing to parse begin/commit/rollback statements with trailing comments: Add support for trailing comments in begin/commit/rollback statements vitessio/vitess#3613

@guidoiaquinti
Copy link

LGTM

@rafael rafael merged commit 713273a into master Feb 7, 2018
@rafael rafael deleted the slack-sync-upstream/2018-02-07 branch February 7, 2018 17:41
demmer added a commit that referenced this pull request Feb 15, 2018
@demmer
Revert "Merge pull request #71 from tinyspeck/slack-sync-upstream/201…
1faab99 
…8-02-07"

This reverts commit 713273a, reversing
changes made to edc17cd.
@demmer demmer mentioned this pull request Feb 15, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guidoiaquinti guidoiaquinti guidoiaquinti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafael @guidoiaquinti @demmer