Skip to content

fix: Remove internal exception details from API error responses (apn-f6iqg) #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulvanbrenk merged 1 commit into from
Feb 16, 2026
Merged

fix: Remove internal exception details from API error responses (apn-f6iqg) #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions PatchNotes.Api/Routes/UserRoutes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,9 @@ public static WebApplication MapUserRoutes(this WebApplication app)

// PUT /api/users/me - Update current user profile
// Mirrors the webhook path: fetches user from Stytch API, then updates DB
group.MapPut("/me", async (HttpContext httpContext, UpdateUserRequest request, PatchNotesDbContext db, IStytchClient stytchClient) =>
group.MapPut("/me", async (HttpContext httpContext, UpdateUserRequest request, PatchNotesDbContext db, IStytchClient stytchClient, ILoggerFactory loggerFactory) =>
{
var logger = loggerFactory.CreateLogger("PatchNotes.Api.Routes.UserRoutes");
var stytchUserId = httpContext.Items["StytchUserId"] as string;

// Step 1: Fetch fresh user data from Stytch (same as webhook)
Expand All @@ -127,12 +128,13 @@ public static WebApplication MapUserRoutes(this WebApplication app)
}
catch (Exception ex)
{
return Results.Json(new ApiError("Stytch API call failed", ex.Message), statusCode: 502);
logger.LogError(ex, "Stytch API call failed for user {StytchUserId}", stytchUserId);
return Results.Json(new ApiError("Stytch API call failed"), statusCode: 502);
}

if (stytchUser == null)
{
return Results.Json(new ApiError("Could not fetch user from Stytch", stytchUserId), statusCode: 502);
return Results.Json(new ApiError("Could not fetch user from Stytch"), statusCode: 502);
}

// Step 2: Find user in DB (same as webhook)
Expand All @@ -143,7 +145,8 @@ public static WebApplication MapUserRoutes(this WebApplication app)
}
catch (Exception ex)
{
return Results.Json(new ApiError("DB query failed", ex.Message), statusCode: 500);
logger.LogError(ex, "DB query failed for user {StytchUserId}", stytchUserId);
return Results.Json(new ApiError("DB query failed"), statusCode: 500);
}

if (user == null)
Expand All @@ -160,7 +163,8 @@ public static WebApplication MapUserRoutes(this WebApplication app)
}
catch (Exception ex)
{
return Results.Json(new ApiError("DB save failed", ex.Message), statusCode: 500);
logger.LogError(ex, "DB save failed for user {StytchUserId}", stytchUserId);
return Results.Json(new ApiError("DB save failed"), statusCode: 500);
}

return Results.Ok(new UserDto
Expand Down