Referring to Issue #119 #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The colour schema on the pie chart isn't that accurate in nature. Hence a new colour schema has been provided. The issue with the old colour schema was that beyond a certain number of values the thing got looped and the same colours were used over and over again. Hence making a colour schema which is accurate was of utmost importance and making this thing usable to everyone in a very simpler way. Note to devs - Do lemme know what do think about it
|
Thanks @ChintzRuparel - do you have a screenshot? |
|
Hey @tipsy, As I have edited the file on the GitHub editor I haven't created a build locally. If u merge this on GitHub and apply changes in a different branch I feel the changes can be applied. Thanks, |
|
Screenshot: https://i.imgur.com/iQqp4Sp.png I think these colors are too vibrant/bright |
Agree! |
|
Created new pull request #123 |
1 similar comment
|
Created new pull request #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colour schema on the pie chart isn't that accurate in nature. Hence a new colour schema has been provided.
The issue with the old colour schema was that beyond a certain number of values the thing got looped and the same colours were used over and over again. Hence making a colour schema which is accurate was of utmost importance and making this thing usable to everyone in a very simpler way.
Note to devs - Do lemme know what do think about it