Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove usage of isset, wp_parse_args and default to html generating functions #190

Open
markkap opened this issue Aug 15, 2018 · 0 comments
Open

remove usage of isset, wp_parse_args and default to html generating functions #190

markkap opened this issue Aug 15, 2018 · 0 comments
Assignees
@markkap
Milestone
4.9

Comments

@markkap
Copy link
Collaborator

markkap commented Aug 15, 2018

with the introduction of upgarade_settings and its use to sanitize settings there should not be any reason to have a setting which is not set, therefor the use of the first two can be removed, and the use of defaults can be removed for anything except the generation code for selects
@markkap markkap added this to the 4.9 milestone Aug 15, 2018
@markkap markkap self-assigned this Aug 15, 2018
markkap added a commit that referenced this issue Aug 17, 2018
@markkap
remove the use of wp_parse_args as it is done better in upgrade_setti…
d37355a 
…ngs which is used at all those places #190
markkap added a commit that referenced this issue Aug 17, 2018
@markkap
#190 since we do not have any more a case of "setting is not set" we …
31e3344 
…can remove the need for defaults and checking if a setting is set in admin HTML generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markkap markkap

Labels
None yet
Projects
None yet
Milestone
4.9
Development

No branches or pull requests
1 participant
@markkap