-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused endpoints #656
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There are indeed some good catches that we now can remove:)
Most of the discussion is in a private discourse chat, above I mentioned a few methods that I would like to keep, if we keep them this is ready to go :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the organizer list and add organizer endpoints, as they are conceptually valuable, it can be that they are not embedded in the vuetify UI yet (as this is used not too often) but I then would prefer to incorporate this into the UI soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the all registrations endpoint. If I recall correctly, this should be used in the UI? Maybe this method is duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, the parse_all_runs_of_vm is not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wpuld like to keep the last four methods, as they are conceptually important, but maybe not yet connected to the new vuetify UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep all methods here besides the get host list amd get ova list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to keep this method, as tgis is conceptually important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to keep this, maybe not connected to the new UI, but still valuable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some of the things that I would like to keep, mentioned above :)
Deferred for now since it probably makes more sense to wait for the mentioned endpoints to have their counterparts implemented in the new REST-API:
|
No description provided.