design fix: avoid exposing full collections as mut. This violates enc…

…apsulation logic since collections can be completely modified externally; while in tx pools it is important to make sure various internal collections are maintained consistently (for instance the `ready_transactions` field on `TransactionsPool` needs careful maintenance)

mining/src/mempool/mod.rs

@@ -13,7 +13,7 @@ use self::{
 };
 use kaspa_consensus_core::tx::{MutableTransaction, TransactionId};
 use kaspa_core::time::Stopwatch;
-use std::{collections::hash_map::Entry, sync::Arc};
+use std::sync::Arc;
 
 pub(crate) mod check_transaction_standard;
 pub mod config;
@@ -140,8 +140,8 @@ impl Mempool {
     }
 
     pub(crate) fn update_revalidated_transaction(&mut self, transaction: MutableTransaction) -> bool {
-        if let Entry::Occupied(mut entry) = self.transaction_pool.all_mut().entry(transaction.id()) {
-            entry.get_mut().mtx = transaction;
+        if let Some(tx) = self.transaction_pool.entry_mut(&transaction.id()) {
+            tx.mtx = transaction;
             true
         } else {
             false

mining/src/mempool/model/orphan_pool.rs

@@ -259,23 +259,23 @@ impl OrphanPool {
     fn get_random_low_priority_orphan(&self) -> Option<&MempoolTransaction> {
         self.all_orphans.values().find(|x| x.priority == Priority::Low)
     }
+
+    fn chained_mut(&mut self) -> &mut TransactionsEdges {
+        &mut self.chained_orphans
+    }
 }
 
 impl Pool for OrphanPool {
     fn all(&self) -> &MempoolTransactionCollection {
         &self.all_orphans
     }
 
-    fn all_mut(&mut self) -> &mut MempoolTransactionCollection {
-        &mut self.all_orphans
-    }
-
     fn chained(&self) -> &TransactionsEdges {
         &self.chained_orphans
     }
 
-    fn chained_mut(&mut self) -> &mut TransactionsEdges {
-        &mut self.chained_orphans
+    fn entry_mut(&mut self, transaction_id: &TransactionId) -> Option<&mut MempoolTransaction> {
+        self.all_orphans.get_mut(transaction_id)
     }
 
     fn expire_low_priority_transactions(&mut self, virtual_daa_score: u64) -> RuleResult<()> {

mining/src/mempool/model/pool.rs

@@ -17,10 +17,8 @@ pub(crate) type TransactionsEdges = HashMap<TransactionId, TransactionIdSet>;
 
 pub(crate) trait Pool {
     fn all(&self) -> &MempoolTransactionCollection;
-    fn all_mut(&mut self) -> &mut MempoolTransactionCollection;
 
     fn chained(&self) -> &TransactionsEdges;
-    fn chained_mut(&mut self) -> &mut TransactionsEdges;
 
     fn has(&self, transaction_id: &TransactionId) -> bool {
         self.all().contains_key(transaction_id)
@@ -30,6 +28,8 @@ pub(crate) trait Pool {
         self.all().get(transaction_id)
     }
 
+    fn entry_mut(&mut self, transaction_id: &TransactionId) -> Option<&mut MempoolTransaction>;
+
     /// Returns the number of transactions in the pool
     fn len(&self) -> usize {
         self.all().len()

mining/src/mempool/model/transactions_pool.rs

@@ -108,7 +108,7 @@ impl TransactionsPool {
             self.ready_transactions.insert(id);
         }
         for parent_id in parents {
-            let entry = self.chained_mut().entry(parent_id).or_default();
+            let entry = self.chained_transactions.entry(parent_id).or_default();
             entry.insert(id);
         }
 
@@ -305,19 +305,13 @@ impl Pool for TransactionsPool {
         &self.all_transactions
     }
 
-    #[inline]
-    fn all_mut(&mut self) -> &mut MempoolTransactionCollection {
-        &mut self.all_transactions
-    }
-
     #[inline]
     fn chained(&self) -> &TransactionsEdges {
         &self.chained_transactions
     }
 
-    #[inline]
-    fn chained_mut(&mut self) -> &mut TransactionsEdges {
-        &mut self.chained_transactions
+    fn entry_mut(&mut self, transaction_id: &TransactionId) -> Option<&mut MempoolTransaction> {
+        self.all_transactions.get_mut(transaction_id)
     }
 
     fn expire_low_priority_transactions(&mut self, virtual_daa_score: u64) -> RuleResult<()> {