Run pytest with python 3.7 (close #63) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Run pytest using python 3.7
Some deferred websocket tests can be run now
…elvan/graphql-engine into issue-63
nizar-m
commented
Sep 26, 2019
| # graphql parser can't seem to parse {where: null}, disabling | ||
| # websocket till then | ||
| @pytest.mark.parametrize("transport", ['http']) | ||
| @pytest.mark.parametrize("transport", ['http', 'websocket']) |
There was a problem hiding this comment.
The parse error is fixed in graphene 3. We can run the websocket tests now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #63
Description
Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds