Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Unify colours within each section in Advanced Settings #690

Closed
Jerry23011 opened this issue Oct 3, 2024 · 2 comments
Closed

dev: Unify colours within each section in Advanced Settings #690

Jerry23011 opened this issue Oct 3, 2024 · 2 comments
Assignees
@Jerry23011
Labels
dev

Comments

@Jerry23011
Copy link
Collaborator

Jerry23011 commented Oct 3, 2024 •
edited
Loading

Just want to listen from everyone. Do we want to unify the icon background colour in Advanced Settings per section? Please see Advanced Tab in Arc as an example.

想听一下大家的意见，Advanced Settings 里要不要每个 section 的 icon background 颜色统一，具体设计参考 Arc

截屏2024-10-02 23 19 24
@Jerry23011 Jerry23011 added the dev label Oct 3, 2024
@phlpsong
Copy link
Collaborator

I prefer the arc style.

@tisfeng
Copy link
Owner

tisfeng commented Oct 15, 2024

ok, it seems good.

This way is also simpler. It's not easy to choose an appropriate color for each item 🥹

@Jerry23011 Jerry23011 mentioned this issue Oct 16, 2024
Merged
@tisfeng tisfeng closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jerry23011 Jerry23011

Labels
dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tisfeng @Jerry23011 @phlpsong