Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Advanced settings section colour #696

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Jerry23011
Copy link
Collaborator

Closes #690

  • Unified colour as per section in Advanced Settings.
  • Added a feature to dynamically switch icon colour when HTTP server is enabled/disabled.

Not a pro in design. Please tell me if you have any alternative combinations in mind 🙏

2024-10-15.22.21.04.mov

Co-Authored-By: Phillip <103433299+phlpsong@users.noreply.github.com>
Copy link
Collaborator

@phlpsong phlpsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tisfeng tisfeng merged commit 478f2d4 into tisfeng:dev Oct 17, 2024
4 checks passed
@Jerry23011 Jerry23011 deleted the advanced-settings-section-colour branch October 17, 2024 16:34
@tisfeng
Copy link
Owner

tisfeng commented Oct 20, 2024

@Jerry23011 奇怪,你这边设置页没有遇到这个问题吗? #683 (comment)

@Jerry23011
Copy link
Collaborator Author

Jerry23011 commented Oct 20, 2024

@Jerry23011 奇怪,你这边设置页没有遇到这个问题吗? #683 (comment)

这个应该是 macOS 15 的 SwiftUI 改动,我15虚拟机上能看到

我为了稳定性还在 14 😂,等12月下旬更新

@tisfeng
Copy link
Owner

tisfeng commented Oct 20, 2024

这样啊 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants