Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Defaults package into project and implement Setting - General with SwiftUI #323

Merged
merged 13 commits into from
Jan 14, 2024

Conversation

CanglongCl
Copy link
Collaborator

@CanglongCl CanglongCl commented Jan 13, 2024

close #287

@CanglongCl CanglongCl changed the base branch from main to dev January 13, 2024 06:12
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello CanglongCl, Thank you for your first PR contribution 🎉 CanglongCl

@CanglongCl
Copy link
Collaborator Author

I'm not sure how the project store other type in original storage. To use Defaults with other type like EZLanguage, we need to implement Defaults.Serializable for them. What's our target to refactor them? Write a new one in Swift or maintain objc for a while?

@tisfeng
Copy link
Owner

tisfeng commented Jan 13, 2024

EZLanguage can be rewritten with Swift, however I am not sure if this would affect the objc code that use EZLanguage, as it is used in many places.

If other objc code will not be affected, then EZLanguage can be rewritten directly. If there is an impact, many places will have to make corresponding changes, which may be a lot of work.

Overall, I am in favor of rewriting EZLanguage with Swift.

@CanglongCl
Copy link
Collaborator Author

BTW I think this PR can be just merged. Other related migration can be based on Defaults package.

@CanglongCl
Copy link
Collaborator Author

CanglongCl commented Jan 14, 2024

image

GeneralTab is almost completed except keyboard shortcut section. I've also added the beta feature toggle as mentioned in #321 and #135.

@CanglongCl CanglongCl changed the title Introduce Defaults package into project and implement boolean options in Setting - General SwiftUI View Introduce Defaults package into project and implement Setting - General with SwiftUI Jan 14, 2024
@tisfeng
Copy link
Owner

tisfeng commented Jan 14, 2024

That’s great, it works well.

Just two more options are missing: appearance and font size, could you add those please?

image image

@CanglongCl
Copy link
Collaborator Author

image image

@tisfeng tisfeng merged commit 35222c2 into tisfeng:dev Jan 14, 2024
5 checks passed
@CanglongCl CanglongCl deleted the rewrite-ezconfig branch January 14, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants