-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve Defaults.Key #599
Conversation
ok, I fixed it b2485c3 , please try it again. |
The issue in |
ok, I will take a look later 🥲 |
I tried to reset these keys, but after input new values in supported models, the same issue still exists. Screen.Recording.2024-07-07.at.18.17.11.mov |
After checking, I found that if I turn off OpenAI service, modifying the This is a bug, and I will fix it later. @phlpsong Is this the situation you encountered? iShot_2024-07-07_21.25.36.mp4 |
Not exactly the same, I tried to enable and disable the service, the Use Model still not get updated. Screen.Recording.2024-07-07.at.22.13.12.movI also tried to reset these models first and give a try: Screen.Recording.2024-07-07.at.22.15.37.mov |
No, what I mean is, you must first display a query window, and then turn on OpenAI service, only then will it start listening for changes in Defaults. |
This bug is not easy to resolve, let's merge this PR first, and I'll fix it in another PR later. |
ok, np |
Close #497
This PR does not include functional changes, it reduces a large amount of duplicate code related to LLMStreamService configuration, the main content is as follows:
Defaults.Keys
of LLMStreamService, replacing them with dynamic keys related to serviceType.configurationListItems()
to generate the configuration view.This PR has many changes, hoping it doesn't have any breaking changes, please review carefully.