Migrate localization to dev branch #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
|
Do we need to add support for Traditional Chinese in InfoPlist.xcstrings? #578 
|
|
Of course, let me do it |
|
@choykarl 遇到一个问题，我切换到这个繁体中文分支上，将应用语言改成了繁体中文，然后又切到其他分支，例如 dev，此时运行后发现界面语言有点奇怪，你有空看一下这个问题。 
|
ok |
|
@Jerry23011 这个加拿大英语分支好像还没合到 dev，你看一下要不要继续 #231 |
原来想加来着，后来发现Easydict的LanguageType中没有这个 case，所以我不知道应该怎么加 |
Just figured out how to add the case, please see the latest PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs