Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use simulation key when AppleScipt failed if user disable forced get text #670

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: do not use simulation key when AppleScipt failed if user disable forced get text #670

merged 3 commits into from
Sep 10, 2024

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Sep 7, 2024

@tisfeng tisfeng mentioned this pull request Sep 7, 2024
Closed
6 tasks
phlpsong
phlpsong approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@phlpsong phlpsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisfeng tisfeng merged commit dd6485b into dev Sep 10, 2024
5 checks passed
@tisfeng tisfeng deleted the fix-simulate-getSelectedTextByKey branch September 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlpsong phlpsong phlpsong approved these changes

@choykarl choykarl Awaiting requested review from choykarl

@AkaShark AkaShark Awaiting requested review from AkaShark

@Jerry23011 Jerry23011 Awaiting requested review from Jerry23011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisfeng @phlpsong