-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom prompt for custom openai service #679
Conversation
Please review 🥺 |
🫠 |
I'll review this today |
It seems that you have not enabled "Enable Custom Prompt", and you are using the default translation prompt. |
OK it works now. Is it possible to expand the System prompt and User prompt sections only when users enabled it? |
Good idea, I have changed the code, now it shows custom prompt TextEditor only enabled. |
I tried to add a transition animation, but it looks a bit strange. I'm not very familiar with SwiftUI animations, so if anyone is good at this, please help improve it. iShot_2024-09-24_20.30.37.mp4 |
Easydict/Swift/View/SettingView/Tabs/ServiceConfigurationView/TextEditorCell.swift
Show resolved
Hide resolved
The main reason is that TextEditor and title Text cannot well aligned. Use vertical style will look more clear. |
Vertical +1 |
I would say the latest change is pretty neat without the transition. I thought of DisclosureGroup's animation but don't know how it's implemented. |
ok, I've changed the title and TextEditor to a vertical layout. I tried DisclosureGroup but it doesn't feel right here, just keep it that way for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #434