Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port config subtitle text wrap issue #694

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

phlpsong
Copy link
Collaborator

Before:
Screenshot 2024-10-12 at 11 39 46

After:

Screenshot 2024-10-12 at 11 40 54

@Jerry23011
Copy link
Collaborator

I have no problem building it on my end, but I'm wondering why it couldn't pass the CI?

@phlpsong
Copy link
Collaborator Author

I have no problem building it on my end, but I'm wondering why it couldn't pass the CI?

I guess CI use the different version of Xcode, it's fixed in d4c81f6.

@Jerry23011
Copy link
Collaborator

I have no problem building it on my end, but I'm wondering why it couldn't pass the CI?

I guess CI use the different version of Xcode, it's fixed in d4c81f6.

I see. Then LGTM

@tisfeng
Copy link
Owner

tisfeng commented Oct 13, 2024

Good!

@tisfeng tisfeng merged commit 6a04207 into tisfeng:dev Oct 13, 2024
5 checks passed
@phlpsong phlpsong deleted the phillip/advanced_port_text branch October 13, 2024 14:54
@tisfeng
Copy link
Owner

tisfeng commented Oct 15, 2024

我更新了 CI image,改成了 macos-15 ed04458,现在 Swift Package 可以使用 version 3 了 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants