Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add acknowledgements for SPM and pod #716

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Nov 5, 2024

#705 (comment)

iShot_2024-11-05_23.18.45.mp4

Copy link
Collaborator

@AkaShark AkaShark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to unify the window title bar style for navigation and detail view?
I think it would look better if they all have the style of the detail window
截屏2024-11-05 11 14 17
截屏2024-11-05 11 14 20

@tisfeng
Copy link
Owner Author

tisfeng commented Nov 6, 2024

Yes, I understand your thoughts.

I tried it, but it's not easy to do that.

The outer window is created by us, but the detail window is generated by the system's NavigationStack. I haven't found a good way to modify the height or style of the window title bar, so it's hard to make them uniform.

If you have a solution, please let me know.

@tisfeng tisfeng merged commit 18f5536 into dev Nov 6, 2024
5 checks passed
@tisfeng tisfeng deleted the feat-add-acknowledgements branch November 6, 2024 14:47
@Jerry23011
Copy link
Collaborator

Yes, I understand your thoughts.

I tried it, but it's not easy to do that.

The outer window is created by us, but the detail window is generated by the system's NavigationStack. I haven't found a good way to modify the height or style of the window title bar, so it's hard to make them uniform.

If you have a solution, please let me know.

I see I see.

I know you can add .task to the AcknowListView for some AppKit customisations on the window style, but in my experience it always shatters, so I feel it's better to keep it this way.

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Nov 29, 2024

There is some shiny new Windows APIs available on macOS 15+ which may help solve the issue.

eg.

Resource: https://developer.apple.com/videos/play/wwdc2024/10148

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Nov 29, 2024

Is it possible to unify the window title bar style for navigation and detail view? I think it would look better if they all have the style of the detail window

image image

Do you mean such style?

  • By applying some List and Windows modifier
  • Note some Windows modifier needs macOS 15+
  • Also the Windows modifier only work if we go through SwiftUI.Window not the StaticWindow by AppKit

May not have time for a full PR on communication about the desired style.

Here is a PoC branch for SwiftUI Windows and List customization if someone is willing to pick and merge it.

5c8a224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants