-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pre validate service #727
Conversation
@AkaShark Hi I made some changes to your branch. Now while user click the toggle, it will be turned into a |
@CanglongCl Thank you for your commit! As someone new to SwiftUI, your code helps me learn more, and it improves this feature significantly. |
I improved the UI, aligning the ProgressView and Toggle 0b51d9a BeforeNow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the new localizations, we need to add translations in English, Simplified Chinese, Traditional Chinese, and Slovak.
We just need to ensure that the translations in Chinese and English are correct. As for other languages, such as Slovak, translation tools can be used.
I usually use Cursor for auto-completion, and later there will be users familiar with that language to proofread #708 (comment)
I'm considering removing the en-CA localization because it's almost the same as en, and we're not familiar with it. It's not worth spending time to differentiate between them. Initially, we added en-CA just to provide users with a localization example #231. Moreover, there's now a better Slovak localization example #668. |
That seems like a good way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Easydict/App/Localizable.xcstrings: Language not supported
- Easydict/Swift/View/SettingView/Tabs/TabView/ServiceTab.swift: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
+1 for this |
closed #714