Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom axis scales through common component #7

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Allow custom axis scales through common component #7

merged 4 commits into from
Jan 18, 2022

Conversation

RoryStokes
Copy link
Contributor

No description provided.

huntc
huntc requested changes Jan 16, 2022
View reviewed changes
src/axis.rs Show resolved Hide resolved
src/axis.rs Show resolved Hide resolved
src/horizontal_axis.rs Outdated Show resolved Hide resolved
src/time_axis_scale.rs Outdated Show resolved Hide resolved
@huntc
Copy link
Contributor

huntc commented Jan 16, 2022 •
edited
Loading

Many clippy errors which are failing CI also. Don't forget cargo clippy is your friend. :-)

huntc
huntc requested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@huntc huntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there!

src/axis.rs Outdated Show resolved Hide resolved
src/horizontal_axis.rs Show resolved Hide resolved
src/horizontal_series.rs Show resolved Hide resolved
huntc
huntc approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@huntc huntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntc huntc merged commit 0719863 into titanclass:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntc huntc huntc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoryStokes @huntc @avonow