GetLoginRequestUri Method with optional NameValueCollection parameter and default access_type=offline in GoogleClient to have refresh_token #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for add query string parameters in uri. Added default queryString parameter access_type=offline in GoogleClient, to take refresh_token from googleauth api, that otherwise is not returned. Added OAu
niemyjski
requested changes
Jul 6, 2018
| @@ -74,6 +79,14 @@ public override string Name | |||
| } | |||
|
|
|||
|
|
|||
| public override Task<string> GetLoginLinkUriAsync(string state = null, CancellationToken cancellationToken = default, NameValueCollection parametersCollection = null) | |||
There was a problem hiding this comment.
Any reason this couldn't be a IDictionary<string,string>?
| if (parametersCollection == null) | ||
| parametersCollection = new NameValueCollection(); | ||
| if (!parametersCollection.AllKeys.Contains("access_type")) | ||
| parametersCollection.Add("access_type", "offline"); |
There was a problem hiding this comment.
Is there any documentation this and why it should be the default value?
|
Hello, Can you please make the requested changes. |
niemyjski
reviewed
Nov 27, 2024
| } | ||
|
|
||
| private string Nonce { get; } | ||
| // private string CodeVerifier { get; } |
There was a problem hiding this comment.
Let's remove the dead code and todo's from this pr
niemyjski
reviewed
Nov 27, 2024
Comment on lines
+7
to
+9
| <SignAssembly>true</SignAssembly> | ||
| <AssemblyOriginatorKeyFile>OAuth2.pfx</AssemblyOriginatorKeyFile> | ||
| <DelaySign>false</DelaySign> |
There was a problem hiding this comment.
Suggested change
| <SignAssembly>true</SignAssembly> | |
| <AssemblyOriginatorKeyFile>OAuth2.pfx</AssemblyOriginatorKeyFile> | |
| <DelaySign>false</DelaySign> |
niemyjski
reviewed
Nov 27, 2024
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Newtonsoft.Json" Version="10.0.3" /> | ||
| <PackageReference Include="RestSharp" Version="106.3.0" /> | ||
| <PackageReference Include="RestSharp" Version="106.2.1" /> |
There was a problem hiding this comment.
Any reason for downgrading? If anything we should be moving to the latest, can we revert this change
niemyjski
reviewed
Nov 27, 2024
| @@ -16,3 +16,4 @@ log.txt | |||
| *.userprefs | |||
|
|
|||
| artifacts/ | |||
| OAuth2.Console.Tests/ | |||
There was a problem hiding this comment.
Suggested change
| OAuth2.Console.Tests/ |
niemyjski
reviewed
Nov 27, 2024
| @@ -1,7 +1,7 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 15 | |||
| VisualStudioVersion = 15.0.26730.16 | |||
| VisualStudioVersion = 15.0.27130.2036 | |||
There was a problem hiding this comment.
Can we revert all changes to this file as there wasn't an added test project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetLoginRequestUri Method with optional NameValueCollection parameter
for add query string parameters in uri.
Added default queryString parameter access_type=offline in GoogleClient,
to take refresh_token from googleauth api, that otherwise is not
returned.
Added OAuth.pfx signature with OAuth2 password