Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

버전 관리 방법을 lerna에서 npm version으로 수정합니다. #2001

Closed
wants to merge 2 commits into from

Conversation

pgs787
Copy link
Contributor

@pgs787 pgs787 commented Mar 10, 2022

PR 설명

변경 내역

체크리스트

스크린샷 & URL

@pgs787 pgs787 self-assigned this Mar 10, 2022
@pgs787 pgs787 requested a review from a team as a code owner March 10, 2022 00:09
@pgs787 pgs787 changed the title 버전 관리 방법을 lerna => npm version으로 수정합니다. 버전 관리 방법을 lerna에서 npm version으로 수정합니다. Mar 10, 2022
@pgs787 pgs787 marked this pull request as draft March 10, 2022 00:12
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2001 (d1d127d) into main (25e30fe) will increase coverage by 3.20%.
The diff coverage is 24.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
+ Coverage   26.63%   29.84%   +3.20%     
==========================================
  Files         522      545      +23     
  Lines       10178    10274      +96     
  Branches     3044     3061      +17     
==========================================
+ Hits         2711     3066     +355     
+ Misses       7173     6935     -238     
+ Partials      294      273      -21     
Impacted Files Coverage Δ
...xperiments/src/google-optimize-context/context.tsx 0.00% <0.00%> (ø)
...ments/src/triple-ab-experiment-context/context.tsx 0.00% <0.00%> (ø)
...ckages/action-sheet/src/components/action-item.tsx 66.66% <ø> (-0.99%) ⬇️
packages/ad-banners/src/content-details-banner.tsx 0.00% <0.00%> (ø)
packages/ad-banners/src/horizontal-entity.tsx 0.00% <ø> (ø)
packages/ad-banners/src/horizontal-list-view.tsx 0.00% <0.00%> (ø)
packages/ad-banners/src/list-top-banners.tsx 0.00% <0.00%> (ø)
packages/ad-banners/src/vertical-entity.tsx 0.00% <ø> (ø)
packages/ad-banners/src/vertical-list-view.tsx 0.00% <ø> (ø)
packages/app-banner/src/index.tsx 0.00% <ø> (ø)
... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0eaddd...d1d127d. Read the comment docs.

@polysiya
Copy link
Contributor

npm versionlerna version을 대체할 순 없어요. 일단 각 패키지의 디펜던시 목록에 있는 버전부터 바뀌지 않을 거에요.
npm에서 해당 이슈가 해결된 것은 TF의 postversion에서 npm install 하던 것이 실패하던 것을 다시 정상적으로 돌아가게 해주는 것이죠.

@pgs787
Copy link
Contributor Author

pgs787 commented Mar 10, 2022

npm versionlerna version을 대체할 순 없어요. 일단 각 패키지의 디펜던시 목록에 있는 버전부터 바뀌지 않을 거에요. npm에서 해당 이슈가 해결된 것은 TF의 postversion에서 npm install 하던 것이 실패하던 것을 다시 정상적으로 돌아가게 해주는 것이죠.

그렇네요... 제가 잘 못 접근한 것 같습니다! 감사합니다! 🙇

@pgs787 pgs787 closed this Mar 10, 2022
@drakang4 drakang4 deleted the config/version-up-npm branch April 18, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants