Add support for PySide2 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9d10b26c161850b86a2aa2c9bb67924ea2778f9a
|
Can objbroswer depend on qtpy as a dependency instead of adding it directly in the project? qtpy already supports PySide2 |
|
Hello @amal-khailtash, that would be a better approach! |
|
@NicoRyberg sorry for not responding earlier and thank you for your PR. The reason why I included qtpy in the project was because of issue 119 in qtpy. However, this issue has been resolved for years now, so I decided to follow @amal-khailtash suggestion and make qtpy a regular dependency. I made a new release (1.3.0) that automatically installs qtpy. With this I think I can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for PySide2 binding by setting the QT_API environment variable to 'pyside2'.
Change-Id: I9d10b26c161850b86a2aa2c9bb67924ea2778f9a