Adjust RepHint Parsing #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Jan 18, 2024
titzer
reviewed
Jan 23, 2024
aeneas/src/vst/Parser.v3
Outdated
| def parsePacking(p: ParserState) -> VstPacking { | ||
| if (p.curByte == '0') { | ||
| p.eat1(); | ||
| p.req1('b'); |
There was a problem hiding this comment.
We'll want to allow uppercase 'B' to be consistent with binary literals.
aeneas/src/vst/Parser.v3
Outdated
| var chars = Vector<u8>.new(); | ||
| while (q < p.input.length) { | ||
| var c = p.input[q]; | ||
| if (c == '0' || c == '1' || Char.isIdentStart(c)) chars.put(c); |
aeneas/src/vst/Parser.v3
Outdated
| } else if (Char.isIdentStart(p.curByte)) { | ||
| var packingName = parseIdentVoid(p); | ||
| var fields = parseList(0, p, '(', COMMA, ')', parseIdentVoid); | ||
| return VstPacking.Params(packingName.name, fields.map(asToken)); |
There was a problem hiding this comment.
You can use VstIdent<void>.name as a getter method here.
aeneas/src/vst/Parser.v3
Outdated
| var result: VstRepHint; | ||
| if (Strings.equal(name, "boxed")) result = VstRepHint.Boxed; | ||
| else if (Strings.equal(name, "unboxed")) result = VstRepHint.Unboxed; | ||
| else if (Strings.equal(name, "packing")) { |
There was a problem hiding this comment.
Packing is a keyword now; let's introduced KC_PACKING to allow it (but not other keywords) here.
aeneas/src/vst/Vst.v3
Outdated
|
|
||
| type VstPacking { | ||
| case Bits(rep: string); | ||
| case Params(packingName: Token, fields: VstList<Token>); |
There was a problem hiding this comment.
What about making the fields a VstList<Expr>? That way we can accommodate VarExpr and Literal.
|
Can you bump the version number and I'll merge this? |
titzer
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.