Packing Declaration Parsing #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Feb 15, 2024
aeneas/src/vst/Parser.v3
Outdated
| p.error("size expected"); | ||
| return 0; | ||
| } | ||
| else return u8.!(V3.unboxI32(sizeLiteral.val)); |
There was a problem hiding this comment.
I think we want to keep this as a literal, so that it can be checked in the Verifier that it's a reasonable size.
aeneas/src/vst/Vst.v3
Outdated
| case Other(hint: string); | ||
| } | ||
|
|
||
| type VstPacking { | ||
| type VstPackingExpr { | ||
| case Bits(rep: string); |
There was a problem hiding this comment.
Should we make a variant here for the bits and store an array of them? E.g.
type PackingBit {
case Literal(val: u1);
case Wildcard;
case Char(ch: byte);
}
titzer
approved these changes
Feb 16, 2024
| @@ -0,0 +1,2 @@ | |||
| //@parse | |||
There was a problem hiding this comment.
Can you add some negative parsing tests as well? Also, some simpler cases with only one field, some parts are missing, etc?
aeneas/src/vst/VstPrinter.v3
Outdated
| def printPacking(p: VstPacking) { | ||
| def printPackingBits(bits: Array<PackingBit>) { | ||
| Terminal.put("0b"); | ||
| for (bit in bits) { |
There was a problem hiding this comment.
Maybe add a _ every four or eight bits?
titzer
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
VstPackingDeclandVstPackingExpr, allowing for nested packing expressions and packing literals.