Enable fully-unboxed Variants #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btwj
force-pushed
the
variant-unbox-2
branch
from
eef6364 to
358560c
Compare
|
Rebased to incorporate new unboxing tests in CI |
titzer
approved these changes
Feb 27, 2024
| match (t) { | ||
| x: ClassType => return true; | ||
| x: ArrayType => return true; | ||
| _ => return false; |
There was a problem hiding this comment.
Can you add an XXX here? I think FUNCREF will be OK here. (I would suggest adding it now, but there aren't tests for it yet, so better to be conservative to land this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
VariantNormto support fully unboxed variants, i.e. every single case is fully unboxed as scalars.