Yonah arm64 backend updates #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
approved these changes
Mar 26, 2024
aeneas/src/arm64/Arm64Backend.v3
Outdated
| config.ExplicitDivChecks = true; | ||
| config.ExplicitModChecks = true; | ||
| config.IntConvertFUnsigned = false; // no unsigned conversions until AVX? | ||
| config.IntConvertFMapsNanToZero = false; // cvts{s,d}2si maps NaN to int.min |
There was a problem hiding this comment.
I think these comments aren't accurate for arm.
aeneas/src/arm64/Arm64Backend.v3
Outdated
| def genEntryStub() { | ||
| prog.ERROR.unimplemented(); | ||
| mach.fail("not implemented"); |
There was a problem hiding this comment.
I think it'd be helpful to introduce a method that is unimplemented() to save a little redundancy.
|
This will need to be rebased on the newest changes. |
YonahGoldberg
force-pushed
the
yonah-arm64-backend-updates
branch
from
55eff9b to
5aabaf0
Compare
titzer
approved these changes
Apr 8, 2024
|
|
||
| // Override Arm64Backend | ||
|
|
||
| def genSigHandlerInstall(signo: int, handler: Addr) { unimplemented(); } |
|
add00 and add01 are working: 
|
titzer
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arm64 backend refactoring to pave way for assembler support.