fix: double-encoding paths correctly #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now failing the two `post-x-www-form` tests, maybe because they added content-length values?
But encode slightly fewer chars to match the aws-sdk-js version
turns out it was fine!
Mocked out the fake module it injects as well and removed babel plugin
Only CJS version for now, but someday maybe UMD?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Fixes #17
After a bunch more research I discovered that some of the AWS sigv4 test suite tests are bunk which explains why the previous behavior wasn't to spec. neat. Fixed that all up, and while I was in there removed a dependency, added basic S3 support, and generally tidied the place up.