Skip to content

Commit

Permalink
fix(processor): cleaning up
Browse files Browse the repository at this point in the history
  • Loading branch information
tivac committed Feb 3, 2022
1 parent 46c80da commit 897a2c5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 18 deletions.
1 change: 1 addition & 0 deletions packages/processor/lib/keys.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ exports.isValue = (key) => key.startsWith(VALUE_PREFIX);

exports.FILE_PREFIX = FILE_PREFIX;
exports.SELECTOR_PREFIX = SELECTOR_PREFIX;
exports.VALUE_PREFIX = VALUE_PREFIX;
9 changes: 3 additions & 6 deletions packages/processor/plugins/values-import.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@ module.exports = () => ({
throw rule.error(`Could not find @value ${name} in "${parsed.source}"`);
}

const sourceKey = processor._addValue(file, name);
const nameKey = processor._addValue(from, name);

processor.graph.addDependency(nameKey, sourceKey);
processor._addDependency({ name : from, dependency : file, refs : [{ name }] });

values[name] = {
...value,
Expand All @@ -58,10 +55,10 @@ module.exports = () => ({
}

processor._addValue(file, parsed.name, { namespace : true });

for(const key in source.values) {
const name = `${parsed.name}.${key}`;

values[name] = {
...source.values[key],
external : true,
Expand Down
16 changes: 4 additions & 12 deletions packages/processor/processor.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,17 @@ const pluginValuesImport = require("./plugins/values-import.js");
const pluginValuesLocal = require("./plugins/before/values-local.js");
const pluginValuesReplace = require("./plugins/values-replace.js");

const keys = require("./lib/keys.js");

const {
selectorKey,
fileKey,
valueKey,

filterByPrefix,

isFile,
isSelector,
isValue,

FILE_PREFIX,
} = require("./lib/keys.js");
} = keys;

let fs;

Expand Down Expand Up @@ -638,12 +636,6 @@ class Processor {
}

// Static exports of key.js functionality
Processor.selectorKey = selectorKey;
Processor.fileKey = fileKey;
Processor.valueKey = valueKey;

Processor.isFile = isFile;
Processor.isSelector = isSelector;
Processor.isValue = isValue;
Object.assign(Processor, keys);

module.exports = Processor;

0 comments on commit 897a2c5

Please sign in to comment.