Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default empty string for assetFileNames #447

Closed
kevinkace opened this issue Jul 12, 2018 · 1 comment
Closed

Default empty string for assetFileNames #447

kevinkace opened this issue Jul 12, 2018 · 1 comment

Comments

@kevinkace
Copy link
Contributor

kevinkace commented Jul 12, 2018 •
edited
Loading

I'm upgrading from modular-css/rollup@8 to modular-css-rollup@12 and ran into an issue:

TypeError: Path must be a string. Received undefined
at assertPath (path.js:28:11)
at Object.join (path.js:489:7)
at Object.generateBundle (D:\thing\build\node_modules\modular-css-rollup\rollup.js:100:27)

(excuse the emoji 💯, it's line 100)

Is a fallback needed rollup.js line 102, similar to line 98?

Your note from gitter:

or even better would be to merge outputOptions w/ some defaults so that doesn't bite me again in the future
tivac added a commit that referenced this issue Jul 12, 2018
@tivac
fix: support no assetFileNames configuration
85aa9b9 
Fixes #447
@tivac tivac mentioned this issue Jul 12, 2018
Merged
tivac added a commit that referenced this issue Jul 12, 2018
@tivac
fix: support no assetFileNames configuration (#448)
9e495dc 
Fixes #447
@tivac
Copy link
Owner

tivac commented Jul 13, 2018

This is fixed in modular-css-rollup@13.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tivac @kevinkace