Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumes import Link from 'components/link' is same as <link> tag in /svelte package #711

Closed
destructobeam opened this issue Jan 4, 2020 · 1 comment · Fixed by #744
Closed

Comments

@destructobeam
Copy link

When preprocessing a .svelte file, compiling errors due to seeing a Link component import/tag as a tag. Whatever is throwing this error probably needs to be case sensitive, as I would think that is a pretty common import/component name.

Example to reproduce

<script>
  import Link from './link'; // Doesnt' matter what is in this component, error is on import.
</script>

<Link />

<style>
   /* Need a style block to throw incorrect conflict error between <style> and <link> tags */
  .something { }
</style>

Expected Behavior

Should work without errors.

Current Behavior

Compile errors warning

Possible Solution

Change regex or whatever to case sensitive.

Sorry for not filling out everything, looking at other solutions atm, just letting you know, hopefully to help.

Cheers.

@destructobeam destructobeam changed the title Assumes import Link from 'components/link' is <link> tag in /svelte package Assumes import Link from 'components/link' is same as <link> tag in /svelte package Jan 4, 2020
tivac added a commit that referenced this issue Apr 8, 2020
Because matching <Link /> is stupid.

Fixes #711
@tivac tivac closed this as completed in #744 Apr 8, 2020
tivac added a commit that referenced this issue Apr 8, 2020
Because matching <Link /> is stupid.

Fixes #711
@tivac
Copy link
Owner

tivac commented Apr 21, 2020

This is released in @modular-css/svelte@25.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants