Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svelte): case-sensitive matching on <link> #744

Merged
merged 1 commit into from
Apr 8, 2020
Merged

fix(svelte): case-sensitive matching on <link> #744

merged 1 commit into from
Apr 8, 2020

Conversation

tivac
Copy link
Owner

@tivac tivac commented Apr 8, 2020

Description

Remove the i flag from the regex that matches <link> so it can't match <Link>

Motivation and Context

Fixes #711

How Has This Been Tested?

Added a test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tivac
fix(svelte): case-sensitive matching on <link>
efe13ad 
Because matching <Link /> is stupid.

Fixes #711
@tivac tivac self-assigned this Apr 8, 2020
@tivac tivac merged commit 8577e3f into master Apr 8, 2020
@tivac tivac deleted the svelte-case-sensitive-link-tags branch April 8, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tivac tivac

Labels
bugfix pkg:svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assumes import Link from 'components/link' is same as <link> tag in /svelte package
1 participant
@tivac