Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rollup peer dependency to support v2 #776

Closed
vladshcherbin opened this issue Jul 30, 2020 · 3 comments · Fixed by #777
Closed

Bump rollup peer dependency to support v2 #776

vladshcherbin opened this issue Jul 30, 2020 · 3 comments · Fixed by #777

Comments

@vladshcherbin
Copy link

👋 Hey, I've tried to install current latest version for rollup (25.8.0) and it gave me a warning:

warning " > @modular-css/rollup@25.8.0" has incorrect peer dependency "rollup@^1.1.2".

I found recent #733 about rollup 2. Would be awesome to see this warning go away 🙌

Expected Behavior

No warnings on installation.

Current Behavior

Warning during installation.

Possible Solution

Bump rollup peer dependency.

Steps to Reproduce (for bugs)

  1. Create new project
  2. Add rollup >= 2
  3. Install latest plugin version

Context

Tried to switch from css modules and saw a welcome warning 😢

Your Environment

Executable Version
modular-css 25.8.0
yarn --version 1.22.4
node --version 14.0.0
OS Version
macOS Mojave 10.14.6
@tivac
Copy link
Owner

tivac commented Jul 30, 2020

Whoops 🤦🏻‍♂️. Thanks for the report! A PR would be great, if not I'll try to get to this soon.

@tivac
Copy link
Owner

tivac commented Jul 30, 2020

Fixed in @modular-css/rollup@25.8.1 (also fixed/published @modular-css/rollup-rewriter@25.8.1 while I was at it)

@vladshcherbin
Copy link
Author

@tivac thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants