Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rollup rebuilds in watch mode #449

Merged
merged 28 commits into from
Jul 12, 2018
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1110fad
test: split out rollup watching tests
tivac Jul 11, 2018
3f66cca
test: make test util helpers smarter
tivac Jul 11, 2018
7da3305
wip: debug logging
tivac Jul 11, 2018
8c69164
fix: remove only removes specified files
tivac Jul 11, 2018
e63da33
test: fix rollup tests
tivac Jul 12, 2018
763fa73
Revert "test: make test util helpers smarter"
tivac Jul 12, 2018
f9f5f22
test: rollup tests passing again
tivac Jul 12, 2018
9c9bef3
fix: update browserify for .remove
tivac Jul 12, 2018
46df927
test: clean up old test
tivac Jul 12, 2018
d7a0866
fix: remove unused dependency
tivac Jul 12, 2018
92ac259
test: update tests for .remove
tivac Jul 12, 2018
baff5c9
chore: remove logging
tivac Jul 12, 2018
f84a793
feat: add processor.dependants
tivac Jul 12, 2018
daa3e44
fix: rollup using .dependants
tivac Jul 12, 2018
dcc829a
fix: use .dependants instead of ._graph
tivac Jul 12, 2018
4d4e259
test: more complicated watching test
tivac Jul 12, 2018
d20b838
test: rename test
tivac Jul 12, 2018
a377389
test: rename more tests
tivac Jul 12, 2018
de5cef7
test: more test shuffling
tivac Jul 12, 2018
140bb55
wip: investigating
tivac Jul 12, 2018
45ec86d
refactor: rename .dependants to .dependents
tivac Jul 12, 2018
d6791ff
fix: rollup handles watch updates correctly
tivac Jul 12, 2018
72e0381
test: composes changes
tivac Jul 12, 2018
93863f6
refactor: use .dependents
tivac Jul 12, 2018
1c806cd
chore: :lock: updates yay
tivac Jul 12, 2018
9d3d193
test: remove invald snapshot
tivac Jul 12, 2018
2b1656c
style: remove debugging statements
tivac Jul 12, 2018
b3cec9f
fix: update assetFileNames test to use prefix()
tivac Jul 12, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: 🔒 updates yay
tivac committed Jul 12, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 1c806cdc150e061331bf1221103d4d616f055dfa
29 changes: 7 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/browserify/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions packages/browserify/test/__snapshots__/watchify.test.js.snap
Original file line number Diff line number Diff line change
@@ -17,3 +17,9 @@ exports[`/browserify.js watchify shouldn't explode on invalid CSS 1`] = `
.mc6204d2f5_wooga { color: blue; }
"
`;

exports[`/browserify.js watchify shouldn't explode on invalid CSS 2`] = `
"/* packages/browserify/test/output/watchify/watched.css */
.mc6204d2f5_wooga { color: blue; }
"
`;
1 change: 0 additions & 1 deletion packages/cli/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/glob/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/postcss/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/rollup/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/svelte/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/webpack/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/www/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.