Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper asset attribution #554

Merged
merged 9 commits into from
Jan 25, 2019
Merged

fix: proper asset attribution #554

merged 9 commits into from
Jan 25, 2019

Commits on Jan 24, 2019

  1. feat: split out usage into dynamic vs static 

    BREAKING CHANGE:

Bundles will now have a `assets` and `dynamciAssets` array on them, and the metadata file will now contain an `assets` and `dynamicAssets` keys on them as well.
    @tivac
    tivac committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    172b404 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. wip: flag nodes as their type 

    Then use that to create `assets` and `dynamicAssets` correctly.
    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    76af73b View commit details
    Browse the repository at this point in the history

  2. wip: switch to using dynamicAssets property

    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    ec2e5ed View commit details
    Browse the repository at this point in the history

  3. test: update tests to use it.each 

    Also updated snapshot and specimens
    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    8c008ff View commit details
    Browse the repository at this point in the history

  4. wip: filter out invalid deps

    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    2fc89b8 View commit details
    Browse the repository at this point in the history

  5. WIP: don't include dependencies 

    TODO: Totally breaks rewrite so I'll need to figure out what happened there later.
    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    be7b3b9 View commit details
    Browse the repository at this point in the history

  6. test: updated snapshot with a new log

    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    c1f3f2a View commit details
    Browse the repository at this point in the history

  7. wip: adjustment to the change in asset attachment

    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    c470d95 View commit details
    Browse the repository at this point in the history

  8. wip: bump rollup version & remove safety checks

    @tivac
    tivac committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    dfe044d View commit details
    Browse the repository at this point in the history