-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dependency processing race condition #565
Conversation
(still fails though, fortunately)
Instead of just waiting for the first postcss pass.
Since the bug isn't technically *in* the svelte preprocessor
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
- Coverage 99.06% 98.97% -0.09%
==========================================
Files 49 49
Lines 1173 1176 +3
Branches 183 183
==========================================
+ Hits 1162 1164 +2
- Misses 11 12 +1
Continue to review full report at Codecov.
|
I'm not sure if this is related, but sometimes I get |
Description
Ensure that walking the tree has completed before allowing exports/dependency information to be flattened.
Motivation and Context
If you called
processor.string()
orprocessor.file()
on two files with shared dependencies w/o waiting for the first file to complete it's walk of the tree you could get random errors that made no sense.How Has This Been Tested?
Added a svelte & non-svelte test for it.
Types of changes
Checklist: