fix(rollup-rewriter): include static dependencies #577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At dayjob ™️ a coworker ran into an issue where a dynamically loaded chunk that was being rewritten to include its CSS deps some of those deps were missing. Turns out that
@modular-css/rollup-rewriter
didn't include the CSS required by any staticimports
contained within the dynamic import chunk entry point.So now it does.
Motivation and Context
Dynamic chunk entrypoints that have static dependencies that include CSS should be properly loaded.
How Has This Been Tested?
Added specimens & a test. Verified it failed before this change, then passes afterwards.
Types of changes
Checklist: