feat(processor): add processor.resolve() #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for m-css failed. Built with commit c81ee19 https://app.netlify.com/sites/m-css/deploys/5db7ce354453800008cdb712 |
tivac
force-pushed
the
processor-resolve
branch
from
ee17c65
to
c81ee19
Compare
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 45 45
Lines 1154 1154
Branches 179 179
=======================================
Hits 1136 1136
Misses 15 15
Partials 3 3
Continue to review full report at Codecov.
|
And update the tests that were already using the `._resolve()` version.
Fixes #679 by allowing the svelte preprocessor to use the same file resolution logic that the modular-css processor is using.
Travis already does it, and it's mostly noise.
tivac
force-pushed
the
processor-resolve
branch
from
c81ee19
to
adc139a
Compare
|
This is released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposed previously private(ish)
processor._resolve()asprocessor.resolve()so it's obvious that it's fine and reasonable for consumers to use it.Motivation and Context
Fixes #679 by allowing the svelte preprocessor to use the exact same file resolution logic as the core
modular-csspackage.How Has This Been Tested?
Added a new svelte test, all existing tests still pass.
Types of changes
Checklist: