feat(svelte): warn on unquoted class attributes #690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warn users whenever an unquoted
class={css.foo}
is discovered.Motivation and Context
The svelte preprocessor can create subtle bugs in cases where the user types something like
class={css.foo}
, this is fine assuming thatcss.foo
is replaced with a single class but fails hard if there's any composition involved.Single-class case ✔
which is treated by the browser as
<div class="foo">
Multi-class case 💀
which is treated by the browser as
<div class="foo" bar>
, which is definitely a problem.More background on unquoted attributes is available from Mathias Bynens.
How Has This Been Tested?
Added tests!
Types of changes
Checklist: