Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(processor): don't scope @keyframes contents #781

Merged
merged 1 commit into from
Sep 2, 2020
Merged

fix(processor): don't scope @keyframes contents #781

merged 1 commit into from
Sep 2, 2020

Conversation

tivac
Copy link
Owner

@tivac tivac commented Sep 2, 2020

Description

Early-out from scoping when the parent of the node is a @keyframes block.

Motivation and Context

https://m-css.com/repl/#NrBEHoFsEMEsDsB0BjAzq0AaUABA1gKYCeAZgE7SQGoAEJA9vTQN4A68NrALgAyICMAVgCkLdjQmSJyegBt6ZAFw0yBACYBucZIC+7HaAC6hoA

image

How Has This Been Tested?

Added a test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tivac tivac self-assigned this Sep 2, 2020
@tivac tivac merged commit dd41bf1 into main Sep 2, 2020
@tivac tivac deleted the keyframe-scoping-fix branch September 2, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tivac tivac

Labels
bugfix pkg:processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tivac