Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): get REPL working again #797

Merged
merged 11 commits into from
Jul 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ module.exports = {
{ blankLine : "any", prev : "directive", next : "directive" },
],

"jest/no-test-callback" : "warn",
"jest/no-try-expect" : "warn",
"jest/no-try-expect" : "warn",
},
};
49,056 changes: 38,604 additions & 10,452 deletions package-lock.json

Large diffs are not rendered by default.

19 changes: 10 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,33 +27,34 @@
"devDependencies": {
"@modular-css/test-utils": "file:packages/test-utils",
"@modular-css/website": "file:packages/www",
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-node-resolve": "^13.0.0",
"@tivac/eslint-config": "^2.4.0",
"babel-eslint": "^10.1.0",
"browserify": "^16.2.3",
"cli-tester": "2.0.0",
"cssnano": "^4.1.10",
"cssnano": "^5.0.6",
"dedent": "0.7.0",
"dentist": "1.0.3",
"env-cmd": "^10.0.1",
"eslint": "^7.20.0",
"eslint-plugin-jest": "^23.0.2",
"eslint-plugin-jest": "^24.3.6",
"factor-bundle": "2.5.0",
"from2-string": "1.1.0",
"jest": "^26.6.3",
"jest-cli": "^26.6.3",
"jest": "^27.0.6",
"jest-cli": "^27.0.6",
"lerna": "^3.22.1",
"node-notifier": "^10.0.0",
"p-defer": "^3.0.0",
"pegjs": "0.10.0",
"read-dir-deep": "^7.0.1",
"rollup": "^2.32.0",
"rollup": "^2.53.2",
"rollup-plugin-hypothetical": "^2.1.0",
"rollup-plugin-svelte": "^5.0.3",
"rollup-plugin-svelte": "^7.1.0",
"shelljs": "^0.8.4",
"sirv": "^0.4.2",
"snapshot-diff": "^0.8.1",
"sugarss": "^2.0.0",
"svelte": "^3.6.9",
"sugarss": "^4.0.1",
"svelte": "^3.38.3",
"watchify": "^3.11.1",
"webpack": "^4.30.0"
},
Expand Down
5 changes: 3 additions & 2 deletions packages/browserify/test/browserify.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe("/browserify.js", () => {
expect(error).not.toHaveBeenCalled();
});

// eslint-disable-next-line jest/no-test-callback
// eslint-disable-next-line jest/no-done-callback
it("should error if an invalid extension is applied", (done) => {
const build = browserify();

Expand All @@ -38,7 +38,7 @@ describe("/browserify.js", () => {
build.plugin(plugin, { ext : false });
});

// eslint-disable-next-line jest/no-test-callback
// eslint-disable-next-line jest/no-done-callback
it("should error on invalid CSS", (done) => {
const build = browserify({
entries : from("require('./packages/browserify/test/specimens/invalid.css');"),
Expand All @@ -54,6 +54,7 @@ describe("/browserify.js", () => {
expect(err).toBeTruthy();

if(errors === 1) {
// eslint-disable-next-line jest/no-conditional-expect
expect(err.name).toMatch(/SyntaxError|CssSyntaxError/);

return false;
Expand Down
2 changes: 1 addition & 1 deletion packages/browserify/test/issue-313.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const plugin = require("../browserify.js");
describe("/browserify.js", () => {
describe("/issues", () => {
describe("/313", () => {
// eslint-disable-next-line jest/no-test-callback
// eslint-disable-next-line jest/no-done-callback
it("should include all dependencies after watchify update", (done) => {
const build = browserify(
from(dedent(`
Expand Down
4 changes: 2 additions & 2 deletions packages/browserify/test/watchify.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe("/browserify.js", () => {
afterAll(() => shell.rm("-rf", "./packages/browserify/test/output/watchify"));

// NOTE: Other watchify tests are in issue files
// eslint-disable-next-line jest/no-test-callback
// eslint-disable-next-line jest/no-done-callback
it("shouldn't cache file contents between watchify runs", (done) => {
const build = browserify();

Expand Down Expand Up @@ -54,7 +54,7 @@ describe("/browserify.js", () => {
});
});

// eslint-disable-next-line jest/no-test-callback
// eslint-disable-next-line jest/no-done-callback
it("shouldn't explode on invalid CSS", (done) => {
const build = browserify();
let wait;
Expand Down
Loading