Vite updates & invalidation fixes #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Invalidating a file invalidates all of it's selectors _AND_ values now - When a file is re-walked all selector and value dependencies are removed, so they can be re-added by the walk with the latest information
Handling a few edge cases
🦋 Changeset detectedLatest commit: 811f50b The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for m-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 37 37
Lines 1441 1452 +11
Branches 237 240 +3
=======================================
+ Hits 1437 1448 +11
Misses 4 4
☔ View full report in Codecov by Sentry. |
Was previously doing all the files _upstream_ of the changed file, but the correct direction is **downstream**.
It happens when a file is re-walked now, instead of per-selector during addSelector. This approach ensures that a) @value are cleared out and b) removed selectors are also cleared out
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working to make vite reloading more reliable, especially around dependencies. Also fixing an issue that could leave stale compositions around when re-running the processor against invalidated files.
Motivation and Context
vite reload behavior has been extremely annoying at my day job.
How Has This Been Tested?
Manual testing only so far.
Types of changes
Checklist: