-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure that aliased values get exported #983
Conversation
Make sure that `external` for each value stays legit instead of just splatting the entire value over the top.
🦋 Changeset detectedLatest commit: 639b48a The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for m-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 37 37
Lines 1452 1452
Branches 240 240
=======================================
Hits 1448 1448
Misses 4 4
☔ View full report in Codecov by Sentry. |
Description
Changed things up to make sure that
@value
s are exported, even when they're an alias to an imported name spaced@value
.I also made sure that the exported JS ends with semicolons because I can't believe I never did that before 😒
Motivation and Context
Fixes #982
How Has This Been Tested?
Added a test.
Types of changes
Checklist: