Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure that aliased values get exported #983

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

tivac
Copy link
Owner

@tivac tivac commented Oct 26, 2023

Description

Changed things up to make sure that @values are exported, even when they're an alias to an imported name spaced @value.

I also made sure that the exported JS ends with semicolons because I can't believe I never did that before 😒

Motivation and Context

Fixes #982

How Has This Been Tested?

Added a test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added a changeset for my change.

Make sure that `external` for each value stays legit instead of just splatting the entire value over the top.
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: 639b48a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@modular-css/css-to-js Patch
@modular-css/processor Patch
@modular-css/webpack Patch
@modular-css/rollup Patch
@modular-css/vite Patch
@modular-css/browserify Patch
@modular-css/cli Patch
@modular-css/glob Patch
@modular-css/postcss Patch
@modular-css/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for m-css ready!

Name Link
🔨 Latest commit 639b48a
🔍 Latest deploy log https://app.netlify.com/sites/m-css/deploys/653ace31f7459700077adc23
😎 Deploy Preview https://deploy-preview-983--m-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (832e6aa) 99.72% compared to head (1038dab) 99.72%.

❗ Current head 1038dab differs from pull request most recent head 639b48a. Consider uploading reports for the commit 639b48a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          37       37           
  Lines        1452     1452           
  Branches      240      240           
=======================================
  Hits         1448     1448           
  Misses          4        4           
Files Coverage Δ
packages/css-to-js/css-to-js.js 100.00% <100.00%> (ø)
packages/processor/plugins/before/values-local.js 100.00% <100.00%> (ø)
packages/processor/plugins/values-import.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tivac tivac merged commit 63af4ac into main Oct 26, 2023
10 checks passed
@tivac tivac deleted the wildcard-value-reexport branch October 26, 2023 20:40
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic @value not included in import
1 participant