Fix this plugin with vite dev server
#202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 447fc60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dreuter
force-pushed
the
main
branch
2 times, most recently
from
c21c3da
to
cba646b
Compare
When I was trying to use this plugin as a `vite` plugin, building the
assets worked fine, but starting the dev server failed with the
following message:
```
error when starting dev server:
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
at Object.dirname (node:path:1346:5)
at .../node_modules/rollup-plugin-sizes/index.js:68:48
at Array.map (<anonymous>)
at Object.options (.../node_modules/rollup-plugin-sizes/index.js:68:27)
at PluginContainer.resolveRollupOptions (file://.../node_modules/vite/dist/node/chunks/dep-DG6Lorbi.js:48895:23)
at createPluginContainer (file://.../node_modules/vite/dist/node/chunks/dep-DG6Lorbi.js:48799:19)
at _createServer (file://.../node_modules/vite/dist/node/chunks/dep-DG6Lorbi.js:62752:27)
at async CAC.<anonymous> (file://.../node_modules/vite/dist/node/cli.js:735:20)
```
It seems when the dev server is started, the plugin will receive an
empty (`{}`) config. This then leads to the above error.
Handling this case explicitely solves the problem. The report is only
printed when running `vite build`, but that is okay/preferable for my
usecase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey :)
First of all: Thanks for this great project. Has already proven useful to me :)
However when I was trying to use this plugin as a
viteplugin, building the assets worked fine, but starting the dev server failed with the following message:It seems when the dev server is started, the plugin will receive an empty (
{}) config. This then leads to the above error.Handling this case explicitely solves the problem. The report is only printed when running
vite build, but that is okay/preferable for my usecase.I thought I would open a CR, so that other people using this plugin with
vitedon't run into the same problem :)