update the description of the annotated_arg/ptr spec #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiwaria1
requested changes
Nov 8, 2022
Owner
tiwaria1
left a comment
tiwaria1
left a comment
There was a problem hiding this comment.
Looks good, thanks Brox! Minor changes needed.
sycl/doc/extensions/proposed/sycl_ext_oneapi_annotated_arg.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_annotated_arg.asciidoc
Outdated
Show resolved
Hide resolved
|
|
||
| The new property set `PropertyListT` must contain all properties from `P`, | ||
| and if any common property takes a value, the value must be the same. | ||
| The new property set `PropertyListT` contains all properties listed in `props`. |
Owner
There was a problem hiding this comment.
Did spec reviewers request that this wording be changed?
Author
There was a problem hiding this comment.
The underlying pointer is initialized with "Ptr". "P" is used to specify the "PropertyListT" type on the class. The new property set PropertyListT must contain all properties from "P" This wording needs to be changed. Let me know if you like this new one or not
sycl/doc/extensions/proposed/sycl_ext_oneapi_annotated_ptr.asciidoc
Outdated
Show resolved
Hide resolved
tiwaria1
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address comments from Jessica and Joseph, updated description for some functions
Align the constructor for annotated_arg and annoated_ptr
Added a variadic template constructor