[BUG] Files with names containing space might not be detected

[wkillerud]

Is there an existing issue for this?

• I have searched the existing issues

Does this issue exist in the latest version?

• I'm using the latest release

Describe the bug?

My case is a visual diff tool that generates snapshot images in a workflow for new tests. It generates files with names like ComponentName test category test name #number.png.

I tried a regexp to match \.png, but the action didn't pick up the new image.

I've tracked it down to the interplay between git status --porcelain and awk.

To Reproduce

1. Make a new Git repo
2. Create a file containing spaces in its name (touch "foo bar.txt")
3. Run parts of the command from entrypoint.sh (git status --porcelain | awk '{ print $2 }'
4. Notice how the file name is missing its second part and file extension

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04, macos-latest or macos-10.15

Expected behavior?

The awk command should pass the whole file name including extension to grep.

I suggest this change (via Stack Overflow):

    # shellcheck disable=SC2207
-   CHANGED_FILES+=($(git status --porcelain | awk '{ print $2 }' | grep -E "(${path})" || true))
+   CHANGED_FILES+=($(git status --porcelain | awk '{$1=""; print $0 }' | grep -E "(${path})" || true))

If you follow the steps to reproduce, but replace step 3 with git status --porcelain | awk '{$1=""; print $0 }' you should see the whole file name.

Relevant log output

~/repro
> $ git init
Reinitialized existing Git repository in ~/repro/.git/

~/repro
> $ touch "foo bar.txt"

~/repro
> $ git status --porcelain
?? "foo bar.txt"

~/repro
> $ git status --porcelain | awk '{ print $2 }'
"foo

~/repro
> $ git status --porcelain | awk '{$1=""; print $0 }'
 "foo bar.txt"

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thanks for reporting this issue.

[jackton1]

@all-contributors please add @wkillerud for code

[allcontributors]

@jackton1

I've put up a pull request to add @wkillerud! 🎉