-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.20.1 Not Backward Compatible #1073
Comments
Thanks for report. I'll do some investigation. |
Node v0.12.0 (Stable) was released 2015-02-06 Commander v2.0.0 was released on Jul 19, 2013, so Commander 2.x started before node 0.12 and reasonable that 2.x.y should not break in this way despite the age. The fix I made was not essential. I suggest we reverse the change I made in 2.x, if you agree @abetomo ? (I'm happy to do it, but likely to be a couple of days before I have time.) |
Fixed. |
Released a new version, and no further activity in a month. Closing this as resolved. Thanks @abetomo for quick action on this one. People will probably upgrade from Command 2.x to 4.x now, but if anyone hits same issue with 3 we could make the same change there. Feel free to open a new issue if it comes up again, with new information and renewed interest. |
https://github.com/tj/commander.js/blob/master/index.js#L100
// new Set();
Is not compatible. This hit us with pm2 where pm2 includes commander, and pm2 runs on node 0.10.x however it includes updated commander which is now using new Set() which is not supported under 0.10.x. We can not upgrade. Please ensure semantic versioning and move Set() to a different version.
The text was updated successfully, but these errors were encountered: