Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for variadic options #1250

Merged
merged 13 commits into from
Jun 1, 2020
+243 −12
Merged

Add support for variadic options #1250

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1175518
First cut at variadic option implementation
shadowspawn Apr 19, 2020
c728420
Rework variadic regexp
shadowspawn Apr 19, 2020
bde0e61
Add tests for variadic options
shadowspawn Apr 19, 2020
6eb6a51
Add test on non-variadic pattern
shadowspawn Apr 19, 2020
8c88da7
Rethink interation of variadic and coercion function
shadowspawn May 4, 2020
b52e258
Merge remote-tracking branch 'upstream/release/6.x' into feature/vari…
shadowspawn May 30, 2020
a6e51cc
Fix typos
shadowspawn May 30, 2020
6bfb43f
Raise ecmaVersion to eliminate some false positive errors in example …
shadowspawn May 30, 2020
e5ffe3b
Improve variadic option with optional value, zero or more values
shadowspawn May 30, 2020
395f574
Reorder comparison to match previous test
shadowspawn May 30, 2020
8bcbdab
Use consistent test names
shadowspawn May 31, 2020
6c7e8c1
Add example and README for variadic option
shadowspawn May 31, 2020
9704200
Fix typo
shadowspawn May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo
@shadowspawn
shadowspawn committed May 31, 2020
commit 970420010b4043f7b56728be8c18475bfda77602
2 changes: 1 addition & 1 deletion Readme.md
View file
Original file line number Diff line number Diff line change
@@ -284,7 +284,7 @@ error: required option '-c, --cheese <type>' not specified
You may make an option variadic by appending `...` to the value placeholder when declaring the option. On the command line you
can then specify multiple option arguments, and the parsed option value will be an array. The extra arguments
are read until the first argument starting with a dash. The special argument `--` stops option processing entirely. If a value
in specified in the same argument as the option then no further values are read.
is specified in the same argument as the option then no further values are read.

Example file: [options-variadic.js](./examples/options-variadic.js)