tests: remove eslint-disable jest/no-test-callback #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the `done` callback from the test function, we can be using a Promise instead. I've checked that if `resolve` is not called the test fails (timeout).
shadowspawn
approved these changes
Jul 25, 2020
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
|
Released in Commander v6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
I'm proposing a way to remove the use of
// eslint-disable-next-line jest/no-test-callbackin one of the tests.Solution
We can use a Promise to remove the use of the callback.
If
resolveisn't called for some reason, the test will fail after 5 seconds (timeout).ChangeLog