Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the built-in help option #1325

Merged
merged 5 commits into from
Aug 11, 2020

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Aug 8, 2020

Pull Request

Problem

People have asked about disabling the built-in help menu, usually to add their own help option and help handling. (This may be used less if it is possible to customise the help directly: #1296)

See: #1225 for collected issues

Solution

Add support for .helpOption(false) which disables the built-in help option. This is symmetrical with .addHelpCommand(false).

Nice simple change in API and README, but lots of small code changes.

ChangeLog

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Aug 11, 2020
@shadowspawn shadowspawn added this to the v6.1.0 milestone Aug 11, 2020
@shadowspawn shadowspawn merged commit 6b2e42c into tj:develop Aug 11, 2020
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Aug 28, 2020
@shadowspawn
Copy link
Collaborator Author

Released in Commander v6.1
https://github.com/tj/commander.js/releases/tag/v6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants