Back to shared implementation method for .option and .requiredOption #1363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
Implementing
.requiredOption()
using.option()
was very compact, but having second thoughts. Some drawbacks mainly for subclassing:.addOption
without final configuration in the passed option(Prompted by thinking about how to add an override to add a matching
--no
option for every boolean option.)Solution
Just shift the shared code back into
._optionEx
like previous pattern, but with the new code.Much as @abetomo suggested in #1331 (comment) !