-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unknown options check if there is a better error to display #1464
Merged
shadowspawn
merged 13 commits into
tj:develop
from
shadowspawn:feature/unknown-command-before-unknown-option
Feb 5, 2021
Merged
Skip unknown options check if there is a better error to display #1464
shadowspawn
merged 13 commits into
tj:develop
from
shadowspawn:feature/unknown-command-before-unknown-option
Feb 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
changed the title
WIP: Skip unknown options check if there is a better error to display
Skip unknown options check if there is a better error to display
Feb 5, 2021
abetomo
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
shadowspawn
added
the
pending release
Merged into a branch for a future release, but not released yet
label
Feb 5, 2021
shadowspawn
removed
the
pending release
Merged into a branch for a future release, but not released yet
label
Feb 15, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
I think this is working our sensibly. Making changes in a complicated piece of the code so going slowly.
Problem
In Commander v5 we started checking for unknown options in more situations, which was an improvement in many cases. However, it unintentional blocked some "better" errors such as an unknown command, and blocked suggestions for the unknown commands (listener for
command:*
).Related issue: #1460
Solution
Work through cases and don't block a better error by checking for unknown options. Especially, when the issue is likely to be a misspelled command.
ChangeLog
command('*')
and call when command line includes options (Skip unknown options check if there is a better error to display #1464)on('command:*', ...
and call when command line includes unknown options (Skip unknown options check if there is a better error to display #1464)